I have now requested that the Infra team migrate us over to gitbox/github https://issues.apache.org/jira/browse/INFRA-16602
Once that is completed we should merge https://github.com/apache/incubator-airflow/pull/3413 -ash > On 21 Mar 2018, at 15:59, Chris Riccomini <[email protected]> wrote: > > Great, thanks for doing this Ash! > > On Wed, Mar 21, 2018 at 8:14 AM, Ash Berlin-Taylor < > [email protected]> wrote: > >> The vote passed with the following +1's, no -1. >> >> 4+ Binding (PPMC) votes >> Ash Berlin-Taylor, Chris Riccomini, Joy Gao, Maxime Beauchemin >> >> 4+ Non-binding (community) votes >> >> George Leslie-Waksman, Shah Altaf, Matthew Housley, Beau Barker >> >> I have created https://issues.apache.org/jira/browse/AIRFLOW-2238 < >> https://issues.apache.org/jira/browse/AIRFLOW-2238> to say we need to >> update the PR tool. I'm not sure how much time I will have to do this work >> over the next few days/weeks, but if no one else picks it up I'll try and >> get around to it. I think the plan would be: write this feature, get it >> reviewed, but don't merge it, ask ASF Infra team to migrate, than merge in >> this change. >> >> -ash >> >> >>> On 14 Mar 2018, at 21:49, George Leslie-Waksman <[email protected] >> .INVALID> wrote: >>> >>> +1 (non-binding) >>> >>> On Mon, Mar 12, 2018 at 11:51 AM Shah Altaf <[email protected]> wrote: >>> >>>> +1 (non binding) >>>> >>>> @Beau Barker - correct me if I'm wrong - I believe that issues will >> still >>>> remain on Jira. Github will be used just for source control and pull >>>> requests. In the Kylin example, the commit messages contain the Jira >>>> ticket IDs. See: https://github.com/apache/kylin/commits/master >>>> >>>> >>>> >>>> >>>> On Mon, Mar 12, 2018 at 6:25 PM Jakob Homan <[email protected]> wrote: >>>> >>>>>> +1 (binding) >>>>>> >>>>>> For future reference, is this vote for anyone on the mailing list, or >>>> for >>>>>> those with some kind of status in the project? >>>>> >>>>> Matthew - yeah, binding votes are reserved for committers or PMC >>>>> members (depending on the vote). Everyone in the community is >>>>> encouraged to vote, and those with binding votes are expected to pay >>>>> attention to those votes that aren't binding (ie, don't vote something >>>>> through that the larger community is angry about or has noticed >>>>> significant problems with), but in the end, it's the binding votes >>>>> that actually count. Researching a question and voting is a form of >>>>> contribution to the project, so it's never wasted. Brett has a good >>>>> slide on the general way this works: >>>>> https://www.slideshare.net/Hadoop_Summit/the-apache-way-80377908 >>>>> >>>>> -Jakob >>>>> >>>>> On 12 March 2018 at 10:23, Chris Riccomini <[email protected]> >>>> wrote: >>>>>> +1 >>>>>> >>>>>> On Sat, Mar 10, 2018 at 11:18 PM, Maxime Beauchemin < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> +1 (binding) >>>>>>> >>>>>>> On Sat, Mar 10, 2018 at 2:03 PM, Beau Barker < >>>> [email protected] >>>>>> >>>>>>> wrote: >>>>>>> >>>>>>>> +1 for Github. >>>>>>>> >>>>>>>> Also think that moving to Github issues would be a step in the right >>>>>>>> direction. >>>>>>>> >>>>>>>> >>>>>>>>> On 11 Mar 2018, at 05:56, Matthew Housley < >>>>> [email protected]> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> +1 (binding) >>>>>>>>> >>>>>>>>> For future reference, is this vote for anyone on the mailing list, >>>>> or >>>>>>> for >>>>>>>>> those with some kind of status in the project? I find the >>>>> documentation >>>>>>>>> here a little ambiguous: >>>>>>>>> https://httpd.apache.org/dev/guidelines.html#voting >>>>>>>>> Apologies if this has been answered before. >>>>>>>>> >>>>>>>>> On Sat, Mar 10, 2018 at 8:29 AM Ash Berlin-Taylor < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Consider this my +1 (binding) vote for the below proposal. This >>>>> vote >>>>>>>> will >>>>>>>>>> run for 7 days (until 2018-03-17 15:30+00) >>>>>>>>>> >>>>>>>>>> **Proposal**: We switch to using GitHub as our primary repo >>>>>>>>>> >>>>>>>>>> We would still use the Apache Jira for issue/release tracking >>>> etc. >>>>>>>>>> >>>>>>>>>> Benefits: >>>>>>>>>> >>>>>>>>>> The contributors will gain write access to >>>>>>>>>> github.com/apache/incubator-airflow. This would mean we would be >>>>> able >>>>>>>> to: >>>>>>>>>> >>>>>>>>>> - merge directly on github.com >>>>>>>>>> - close stale issues >>>>>>>>>> - be able to re-run Travis jobs (I think/hope) >>>>>>>>>> >>>>>>>>>> Risks: >>>>>>>>>> >>>>>>>>>> Neither of these are likely to be a problem, but the possible >>>>>>> downsides >>>>>>>>>> are: >>>>>>>>>> >>>>>>>>>> - It is still possible to commit to the ASF repo, which if it >>>>> happens >>>>>>>> can >>>>>>>>>> lead to "split brain" (i.e. different views of master) which will >>>>> need >>>>>>>>>> INFRA team support to fix. >>>>>>>>>> >>>>>>>>>> - Contributors will need to agree to Github terms of service. >>>> Given >>>>>>> this >>>>>>>>>> is how PRs are reviewed currently this isn't a problem for any >>>>> current >>>>>>>>>> contributors. Just worth mentioning. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> If the vote passes we will need to: >>>>>>>>>> >>>>>>>>>> - Update the airflow-pr tool to work directly on github, not ASF >>>>> repos >>>>>>>>>> - Update any docs that point to ASF repos ( >>>>>>>>>> http://incubator.apache.org/projects/airflow.html, >>>>>>>>>> https://cwiki.apache.org/confluence/display/AIRFLOW/ >>>>>>> Committers%27+Guide >>>>>>>> - >>>>>>>>>> there might be more) >>>>>>>>>> - Ensure all committers have access. There is an self-serve >>>> process >>>>>>> for >>>>>>>>>> this (see below) >>>>>>>>>> - Open a ticket with the INFRA queue asking them to migrate the >>>>> repos. >>>>>>>> (An >>>>>>>>>> example of ticket from another Apache project that did this >>>>> recently >>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-15983 ) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Contributor set up steps: >>>>>>>>>> >>>>>>>>>> - Go to https://id.apache.org/ and ensure you have a github >>>>> username >>>>>>>>>> entered in your profile. This will send an invite to join the >>>>> Apache >>>>>>>> org on >>>>>>>>>> Github: accept that. >>>>>>>>>> - Go to https://gitbox.apache.org/setup/ and link the accounts >>>>>>>>>> >>>>>>>>>> These steps can be done now no matter the outcome of the vote -- >>>> we >>>>>>> just >>>>>>>>>> won't get write access to airflow unless we migrate. >>>>>>>>>> >>>>>>>>>> Ash >>>>>>>> >>>>>>> >>>>> >>>> >> >>
