- **status**: code-review --> in-progress
- **QA**: Dave Brondsema
- **Comment**:
Looking good. I did get an error when running the trac wiki import from the
web interface (either from /p/import_project/trac/ or under admin, export
menu).
~~~~
Traceback (most recent call last):
File
"/home/dbrondsema/dbrondsema-1019/forge/Allura/allura/model/monq_model.py",
line 267, in __call__
self.result = func(*self.args, **self.kwargs)
File
"/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/base.py",
line 131, in import_tool
mount_point=mount_point, mount_label=mount_label, **kw)
File "/nfs/home/dbrondsema/tracwikiimporter/tracwikiimporter/importer.py",
line 105, in import_tool
load_data(f.name, WikiFromTrac.parser(), options)
File
"/nfs/home/dbrondsema/tracwikiimporter/tracwikiimporter/scripts/wiki_from_trac/loaders.py",
line 56, in load_data
import_wiki(cli, options.project, options.wiki, options, doc_txt)
File
"/nfs/home/dbrondsema/tracwikiimporter/tracwikiimporter/scripts/wiki_from_trac/loaders.py",
line 77, in import_wiki
r = cli.call(url + '/' + title, **page)
File
"/home/dbrondsema/dbrondsema-1019/forge/Allura/allura/lib/import_api.py", line
59, in call
raise e
HTTPError: HTTP Error 403: Forbidden
(http://sf-dbrondsema-1015.sb.sf.net/rest/p/testit/wiki-sivic/osirix_plugin)
~~~~
Since forum import is not documented or tested (and probably not even used
either), I'm not too comfortable with the fact that now any oauth token can use
it, rather than the previous situation that required an import token that site
admins specifically granted import capabilities to. What do you think about
adding back a simple restriction on forum imports? That would mean by default
the feature isn't available but a site admin could turn it on if needed. I'm
thinking maybe something much simpler than the previous admin web interface.
Could be just something like a .ini config option to list bearer tokens and/or
projects that are allowed to use it.
---
** [tickets:#1687] Remove pre-oauth stuff**
**Status:** in-progress
**Milestone:** forge-backlog
**Labels:** cleanup 42cc
**Created:** Wed Mar 09, 2011 07:33 PM UTC by Dave Brondsema
**Last Updated:** Tue May 06, 2014 01:25 PM UTC
**Owner:** nobody
Remove the user preference for the key & secret key, and integration therein.
Remove RestClient, remove server-side validation, etc.
---
Sent from sourceforge.net because [email protected] is subscribed to
https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
