- **status**: code-review --> in-progress - **QA**: Dave Brondsema - **Comment**:
* The `site_name` config var should used instead of using SourceForge name. And I probably wouldn't use the brackets, we don't other places site_name is in a subject * The to header comes through as `To: I[u'[email protected]']` (FYI the "I" is because it's a ming instrumented list) * you included some pydevd debugging lines * Once I realized the To: address needs to be explicitly set, I grepped for other cases where we send individual mail and don't specify a "To". Can you update these too? * Allura/allura/tasks/export_tasks.py * Allura/allura/controllers/auth.py * I wonder if `sendsimplemail()` is better suited for individual mails like these? I haven't looked closely but it has just a single param for to/destinations. which is nice. * If you feel inclined to add docstrings to things like the sendmail functions, feel free :) I think it'd be good to add documentation to things like that where parameter usage (e.g. default "To" value) isn't obvious. We use rst formatting for docstrings. --- ** [tickets:#7526] Fix mail headers in email verification email** **Status:** in-progress **Milestone:** forge-jul-25 **Labels:** bitesize **Created:** Wed Jul 02, 2014 07:27 PM UTC by Dave Brondsema **Last Updated:** Tue Jul 15, 2014 11:30 PM UTC **Owner:** Alexander Luberg In `send_verification_link` we should set headers better: * The To: header is missing * From: should be `g.noreply` (omit Reply-To header, or set the same) * Subject: should include the site name --- Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
