Yes, it seems like `m__add_agpl_and_lppl` duplicates categories that already 
created in main method. I remember that in [#6848] I've compared dumps of all 
categories generated with old command + migration and generated with new 
command and they was identical. As you can see from the commits below, there 
were already duplicates in old command + migration scripts 
(`014-add-trove-category-agpl.py`, `016-add-trove-category-lppl.py`)

`git show 350faaae13433e34f3b161aa9beacdf7ee933f0a`
`git show 77fb5d8c3788ee3d7fa5133354ca38213c8cedb5`

It seems to me that `m__add_agpl_and_lppl` can be removed to avoid duplicates 
(but probably need a script to remove duplicates from mongo instances where 
categories were already created)


---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** in-progress
**Milestone:** forge-aug-22
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Tue Aug 19, 2014 08:03 PM UTC
**Owner:** Dave Brondsema

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly 
picks a trove category to use for the test, and some trove categories are in 
the test data twice, so the lookup fails.  It seems that in 
`allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method 
creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because [email protected] is subscribed to 
https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.

Reply via email to