- **status**: in-progress --> review
- **Comment**:
Implemented in branch db/7800
(SourceForge internally has a configtree branch too)
---
** [tickets:#7800] Standardize IP addr lookup**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-1
**Created:** Thu Nov 20, 2014 07:33 PM UTC by Dave Brondsema
**Last Updated:** Fri Nov 21, 2014 10:01 AM UTC
**Owner:** Dave Brondsema
We do `req.headers.get('X_FORWARDED_FOR', req.remote_addr)` in many places and
`request.headers.get('X-Remote-Addr', request.remote_addr)` in one. We should
standardize this and make the custom header a `.ini` setting so that folks can
use whatever they need (or none) based on their deployment configuration.
I think we should default to none since that is safest. In `development.ini`
we can show an example config for X_FORWARDED_FOR since that is common.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
