---

** [tickets:#7130] Blob.next_commit and prev_commit should be removed**

**Status:** closed
**Milestone:** asf_release_1.2.0
**Labels:** performance sf-1 
**Created:** Tue Feb 04, 2014 06:33 PM UTC by Cory Johns
**Last Updated:** Wed Feb 05, 2014 09:05 PM UTC
**Owner:** Cory Johns

`Blob.context()` (which is called when on the file view page) calls 
`Blob.next_commit` but the result is not used.  `Blob.next_commit` walks down 
the commit tree to find the next commit that modified the file, which for 
rarely modified files can result in a lot of useless work.

`Blob.prev_commit` is more efficient, but is also not used.

Remove both, as well as associated tests in 
`Allura/allura/tests/unit/test_repo.py`, and ensure there is no visible impact 
to the UI of the file view page.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to