- **status**: in-progress --> review
- **Comment**:

Closed #714. `ib/4542` (It's in my fork 
https://forge-allura.apache.org/u/jetmind/allura/ci/master/tree/). Can't push 
it to main repo somehow:

~~~~~
$ git push origin t714_webhooks:ib/4542    
Counting objects: 258, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (83/83), done.
Writing objects: 100% (87/87), 25.78 KiB | 0 bytes/s, done.
Total 87 (delta 66), reused 0 (delta 0)
error: RPC failed; result=56, HTTP code = 0
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
Everything up-to-date
~~~~~

#####  To QA:

To test without any external service I've used http://httpbin.org

- add http://httpbin.org/post as hook url
- add `log.info(r.content)` to `send_webhook` task, after `requests.post` call

http://httpbin.org/post will simply return your request's POST data, headers, 
etc, so you can see what payload actually sent.

But test with something like Travis CI also :)

Also:

- make sure it works for git, svn, mercurial
- test with big pushes (hundreds of commits?)


##### Some optional areas for future improvements (inspired by GitHub mostly):

- thresholds (already have a ticket for it on 42cc side)
- send "ping" event to hook url after configuration, like github does. It's 
useful to ensure that webhook configured properly, without triggering event by 
repo push
- add "ignore insecure ssl" option, it's useful for testing
- support payload with `application/x-www-form-urlencoded` mime type
- show response/error in UI for webhooks fired (last 5 maybe?)



---

** [tickets:#4542] Implement webhooks**

**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-8 42cc 
**Created:** Fri Jul 13, 2012 02:55 PM UTC by Dave Brondsema
**Last Updated:** Fri Jan 16, 2015 05:40 PM UTC
**Owner:** Igor Bondarenko

We should have webhooks, compatible with github & bitbucket.  I don't see a 
spec for SCM webhooks anywhere.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to