- **status**: review --> in-progress - **Comment**: Nice that the admin form change made for cleaner code too :)
Yay for creating the admin_url helper. There's a lot of places that would be a little cleaner with it. Should Webhook.url() use it too? For the payload: * I think we should include the ref like `"ref":"refs/heads/master"` Slack for example renders `[repo-name:branch]` at the beginning of the message, and it currently comes through like `[Code:]` Not sure what value to put there when it's SVN, maybe don't include it for SVN. * Again with slack, if multiple commits are pushed it shows `<|3 new commits>` compared to a github commit which is `3 new commits` linked to the `"compare"` payload URL. Including that would be nice. Might as well include `"before"` and `"after"` hash too. The `_diff` helper is nice. I might be a bit biased (since I wrote it) but give `datadiff.tools.assert_equals` a try. It'll do a diff of the data structure, aware of the semantics of dicts, lists, and how far down they are nested. For SVN, can you change the "id" attribute to have a value like "r1" instead of "54dd2fc2d8be35744298ee3d:1". Mercurial appears to work well (same payload recommendations as above for git). --- ** [tickets:#4542] Implement webhooks** **Status:** in-progress **Milestone:** unreleased **Labels:** sf-current sf-8 42cc **Created:** Fri Jul 13, 2012 02:55 PM UTC by Dave Brondsema **Last Updated:** Wed Feb 11, 2015 04:22 PM UTC **Owner:** Igor Bondarenko We should have webhooks, compatible with github & bitbucket. I don't see a spec for SCM webhooks anywhere. --- Sent from forge-allura.apache.org because [email protected] is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
