- **status**: review --> in-progress
- **Comment**:
Hey Igor, looking good man.
I just have a few notes/questions:
1. When deleting an attachment, should we trigger the changelog()?
2. We should probably toss in an assertion for the changelog comment. something
along the lines of:
* `assert_in('<li><strong>attachments</strong>: --> - test_root.py`...
3. With multiple attachments, the diff comment becomes convoluted and hard to
read. Maybe we can format it so there is one file per line?
Something like:
~~~~~~:::python
def attachments_info(attachments):
# untested
text = []
for attach in attachments:
text.append("{} {} ({}; {})".format('- ', attach.filename,
h.do_filesizeformat(attach.length), attach.content_type))
return "\n".join(text)
~~~~~~
*I'm not sure if #3 conflicts with the mailing list formatting,but it certainly
would look nicer :)*
---
** [tickets:#6017] Should show attachment changelog when ticket gains an
attachment**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** bitesize sf-current sf-1 42cc
**Created:** Tue Mar 26, 2013 08:23 PM UTC by Dave Brondsema
**Last Updated:** Wed Apr 15, 2015 03:09 AM UTC
**Owner:** Igor Bondarenko
When an attachment is added to a ticket *comment*, a nice email is sent with
some attachment info.
When a ticket is edited and an attachment is added, a blank changelog comment
is created and emailed. Instead of being blank, it should contain the same
info as is emailed for an attachment added via comment. E.g. `Attachment:
screenshot.jpg (79.3 kB; image/jpeg)`
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
