- **status**: review --> in-progress - **Comment**: Very minor feedback:
* In both places, `setattr(session, 'skip_mod_date', True)` can be `session.skip_mod_date = True` * In `test_cached_convert`, we should have a comment explaining why `skip_mod_date` is needed to avoid the automatic setting of mod_date when it is saved Bigger: * Since `cached_convert` is being mocked, there's the caching logic will never run at all. We need it to run so the test actually tests it :) I'd just remove that mock. For a strong assertion that it did run, rather than mocking it and checking call_count, we could check that `ticket.description_cache.html` is set... but that requires querying Ming for the record and making sure you get that latest (not cached in the Ming layer) Besides that I think the test approach is fine, even if it's not ideal. --- ** [tickets:#7852] Don't update mod time when viewing artifact creates a cache** **Status:** in-progress **Milestone:** unreleased **Labels:** sf-current sf-2 **Created:** Thu Mar 12, 2015 02:56 PM UTC by Dave Brondsema **Last Updated:** Tue Apr 14, 2015 05:37 PM UTC **Owner:** Heith Seewald In addition to the fixes done in [#7834], a ticket can still be marked as updated just when viewed. This happens if the cache was not created initially (e.g. ticket import - no view, or first view was under the threshold time) and then the cache was created upon a later view. We need to skip updating `mod_date` and `last_updated` when a cache is set. I think it's probably safe to set the `skip_mod_date` and `skip_last_updated` flags on the session, since there shouldn't be cases of rendering a markdown (viewing) in the same session as legitimately updating records (I hope). --- Sent from forge-allura.apache.org because [email protected] is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
