Looking really good overall! I have a few minor notes relating to the .ini file:
1. `line 81` forgemail.url <— what is this and is it normally the same as the base_url? 2. `line 114`: typo in `integratino` 3. `line 126`: what is a: `login_fragment`? 4. `lines 322/323` could use an example use case. 5. `line 370`: poll_interval = unit of time?? 6. `lines: 57, 81, 390-394 ` The forgemail settings are scattered. 7. `line 407`: unit of time? 8. `line 410` — example of a site-wide notification would be nice. 9. `line 426`: A quick def of what `soft-delete` in context of allura 10. `line 485`: I’m getting a 404 for the python logging doc with that url Some indication of how to use inheritance (like you did in the test.ini) to over-ride local settings would be handy. (this may be better in the docs) ** A huge improvement overall!** --- ** [tickets:#7870] Clean up .ini files** **Status:** review **Milestone:** unreleased **Labels:** sf-current sf-2 **Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema **Last Updated:** Thu Apr 16, 2015 05:13 PM UTC **Owner:** Dave Brondsema We should standardize on comment syntax, and add examples/comments for all config values that are possible. --- Sent from forge-allura.apache.org because [email protected] is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
