- **status**: review --> in-progress
- **Reviewer**: Dave Brondsema
- **Comment**:

Very nice.  Just two ways it could be better.  One is getting docs ready for 
https://sourceforge.net/p/forge/documentation/Allura%20API/.  Probably don't 
need to list it on every endpoint, but could mention it once in a general 
section (once [#6797] is done it could be a "trait").

Also the tests are fairly repetitive.  It's not necessarily wrong so I'm not 
saying you have to change this now, but at least in the future consider 
refactoring for some shared helpers (mixins maybe, like you did for the api 
functionality itself).  Test code is code too, and deserves refactoring.



---

** [tickets:#7633] API for has_access**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** allura-api 42cc sf-current sf-2 
**Created:** Thu Aug 21, 2014 06:25 PM UTC by Dave Brondsema
**Last Updated:** Mon May 18, 2015 02:28 PM UTC
**Owner:** Igor Bondarenko

It would be useful to have an API to run `has_access` permission checks so that 
3rd-party clients can rely on Allura permissions.   I think that it would be an 
API per-tool and per-project including neighborhood-projects (whose API needs 
some fixing) and that you would need 'admin' access on the project to use the 
API.  It could take a username and role and return a true/false result.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to