Looks fine to me. `merge_request_commits` is called within downstream context as `c.app.repo.merge_request.commits`, so `self` should equal `c.app.repo` there.
--- ** [tickets:#7882] Option to use a tmp dir for git ops on merge request view** **Status:** review **Milestone:** unreleased **Labels:** sf-current sf-2 **Created:** Fri May 29, 2015 05:32 PM UTC by Dave Brondsema **Last Updated:** Tue Jun 02, 2015 02:37 PM UTC **Owner:** Igor Bondarenko Merge request viewing now (as of [#7836]) will fetch git info into existing git repositories. On deployments where the sysadmins don't want to do writes in existing git repos, we should use a tmp dir. The `--shared` option for `git clone` seems helpful to make it quick. Add an option, perhaps `scm.merge_list.git.use_tmp_dir = true`, to do this. Also log how long it took for each repo, since it is non-trivial code to run during a web request and may be too long for some repos. Logs will provide useful info. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
