These are great notes :)
- I created a ticket to address the updated icons: [#7924].
- Maybe could use a combination of “cursor: wait;” and/or the msg notify system
to indicate request progress/completion?
- If someone is already subscribed to the parent of the current item, I think
it would make more sense to have a "subscribed to {parent}" type label or
something in place of the button.
I like the idea of a tooltip-like message that makes that even clearer. But
yeah, I agree that we probably shouldn’t allow an ‘unsubscribe’ button if
they’re already subscribed to the parent -- that might get confusing.
---
** [tickets:#7685] Subscribe/unsubscribe action should use POST**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Tue Sep 16, 2014 05:35 AM UTC by Igor Bondarenko
**Last Updated:** Mon Jul 13, 2015 10:46 AM UTC
**Owner:** Igor Bondarenko
Currently all of subscribe/unsubscribe buttons (in the topbar of any tool's
page and in the wiki sidebar) are using GET to make an action. Their should
require POST to avoid CSRF.
See also discussion at [#4905]
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
