Updated to 1.5.1.

There's one problem, though. If artifact has a few of comments/replies and 
you're trying to edit one of them in full screen mode, some of them will 
overlap the editor, ignoring it's (higher) z-index.

Basically, the problem is that each comment's "div.row" creates new stacking 
context by using:

    :::css
    position: relative;
    z-index: 0 /* or 1 for parent */
    
The editors are inside these contexts, it means that editors in stacking 
contexts closer to the bottom of the stacking order can't appear in front of an 
element in a different stacking context that is higher in the stacking order, 
no matter what `z-index` is used.  [This 
article](http://philipwalton.com/articles/what-no-one-told-you-about-z-index/) 
really helps in understanding that.

The reason we have `z-index` for each comment is that our top-level comments 
have darker border color than replies, so we need to put replies to the bottom 
of stacking order, so that top border wouldn't overlap with a parent comment's 
bottom border.

If we're feeling fine making border color of the replies the same as top-level 
comment's, then we can fix the issue (see commit `615d4d0`). If not we're 
better off disabling full screen mode I think.

I've tried to keep colors as is and fix border overlap without using z-index, 
e.g. setting `border-top-color: transparent;` for replies but it looks bad.





---

** [tickets:#7948] Cursor position often wrong in new markdown editor**

**Status:** review
**Milestone:** unreleased
**Labels:** ux sf-current sf-4 
**Created:** Mon Aug 03, 2015 07:27 PM UTC by Dave Brondsema
**Last Updated:** Tue Aug 11, 2015 04:28 PM UTC
**Owner:** Igor Bondarenko


When editing text in the new markdown editor, the cursor can be off by a line 
(or few?).  This seems to happen  reliably, but exact cause is not narrowed 
down yet.  Seems to only be when editing existing content, not when creating 
new content (even pasting the exact same text).  I think it has to do with the 
initial height of the input area being tall.  Sometimes I can get the cursor to 
work properly again if I add or delete enough rows to make the textarea resize 
some amount.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to