- **status**: review --> in-progress
- **Comment**:

In `Allura/allura/templates/widgets/repo/tree_widget.html` I think `fa-file-o` 
would be better to use than the `table` icon.

And possibly a bigger issue here - I wish we had noticed this earlier.  When we 
have text inside the `<a>` (or whichever tag) that has `class=fa` then the text 
has different font family and font settings than normal.  The `a.fa > span` 
could be changed to `.fa > span` which would help match more items.  However 
its still not perfect because there are other font settings.  On OSX/FF, 
`-moz-osx-font-smoothing: initial` is necessary to get that setting back to 
normal.  However, the similar `-webkit-font-smoothing` does not necessarily 
need to be overridden since we already set it in our site style.  I haven't 
noticed differences with any of the other kerning or spacing or streching 
rules, but its possible they would pop up in different situations.  So.... it 
seems the best solution would be to not have text inside the tag with `.fa` so 
it doesn't get any style changes.  But that might be a little tedious to change 
Icon.render output, cases where closing tags are handled separately, plus
  all the padding & spacing rules for the `a` and other tags (I did a quick 
test and saw too much space showing up between the icon and the text.  What do 
you think?




---

** [tickets:#7924] Update icons**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** new-admin sf-current sf-4 42cc 
**Created:** Mon Jul 13, 2015 02:22 PM UTC by Heith Seewald
**Last Updated:** Fri Oct 23, 2015 02:49 PM UTC
**Owner:** Igor Bondarenko


Our icons should be updated and support hidpi screens.  [Font 
awesome](http://fortawesome.github.io/Font-Awesome/) might be a good choice or 
possibly [fontello](http://fontello.com/).

Licenses need to be taken into consideration and included in the appropriate 
places.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to