- **status**: review --> in-progress
- **Comment**:
This is great -- I'm excited about this feature :)
This is looking great overall -- I just have a couple of notes:
1: We should add in some warnings instead of failing silently. Maybe
something like:
~~~~
::python
if not os.path.isfile(image_full_path):
log.warning('Could not find logo at: %s' % image_full_path)
return False
if not image_path:
log.warning('Image path not set for nav_logo')
return False
~~~~
2: What do you think about making the image height settable or maybe just
mentioning the ideal image dimensions in the comments?
3: For simple data structures like the one for “logo”, using a simple dot
notation can be more readable:
~~~~
logo.link = /
logo.path = logo.png
~~~~
4: Because this is a universally useful feature -- it may be nice to mention
it in our docs.
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Wed Dec 09, 2015 05:56 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on
the header of all pages. This should be an option for forge deployers, without
having to customize the theme.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
