Hey Pranav -- nice work.  This appears to work well.

The pep8 issues are minor -- but there are a few tools to make checking for 
violations.

I recommend setting up your editor to display pep8 issues in real time -- but 
you can also use [flake8](https://pypi.python.org/pypi/flake8) (which supports 
git diffs).

for example:

`git diff origin/master | flake8 --diff`

gives the following output:

*./Allura/allura/controllers/auth.py:238:40: E231 missing whitespace after ','
./Allura/allura/controllers/auth.py:239:120: E501 line too long (144 > 119 
characters)
./Allura/allura/controllers/auth.py:275:47: E711 comparison to None should be 
'if cond is None:'
./Allura/allura/controllers/auth.py:282:32: E128 continuation line 
under-indented for visual indent
*



---

** [tickets:#8013] New Users should not be displayed in /u/wiki/home until 
email is verified **

**Status:** in-progress
**Milestone:** unreleased
**Created:** Fri Oct 30, 2015 06:05 PM UTC by Heith Seewald
**Last Updated:** Wed Dec 09, 2015 10:44 PM UTC
**Owner:** nobody


Right now new users are displayed in '/u/wiki/home' before email validation.  
The link for that user will just 404 until email is verified.  

This shouldn't apply if `auth.require_email_addr` is set to false in the ini.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to