- **status**: in-progress --> review
- **Comment**:
db/8039
* make sure you install the new npm packages, as noted in the installation
docs. AFAIK they have to be global and can't be specified in `package.js`
because local packages won't add `eslint` to the `PATH`
* `allura.tests.functional.test_static:TestStatic.test_static_controller` is
the only test that exercises JS validation by default
* at the bottom of `Allura/test.ini` you can set `validate_inlinejs` to true
and then all functional tests will do more validation. There are many failures
though.
* Note that when errors are captured and printed to the terminal, unicode
comes through like `\u2716`. This is a limitation in nose, but for our Jenkins
runs that use xunit xml files, the unicode will come through correctly there.
* we have no tests that cover .js files
[#8035] will need to modify `.eslintrc` and/or set up 2 different files. After
that gets sorted out, we probably should make a ticket to enable JS validation
by default and fix all the issues with .js files and inline script.
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Wed Jan 13, 2016 09:36 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead
of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which
currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
