- **status**: review --> in-progress
- **Reviewer**: Dave Brondsema
- **Comment**:
Can we have a separate .eslintrc for ES5 files? The `.eslintrc` file from
master needs to be kept around in some fashion and used in `def validate_js`
so that `allura.tests.functional.test_static:TestStatic.test_static_controller`
and inline_js tests work correctly.
For the `no-unused-var` changes, I prefer to allow unused function params like
`e` for event handlers, `i` for some loops, etc, as an indicator of what the
function signature actually is even if they aren't used. This can be permitted
with `"no-unused-vars": [2, {"vars": "all", "args": "none"}],`. What do you
think?
In the browser, I get an error "ReferenceError: module is not defined".
Grouping threshold input box shows up at the wrong time, I think the `!!` ->
`Boolean` change messed it up. Also its tooltip has backslashes in it.
---
** [tickets:#8035] Finalize frontend eslint/jscs setup**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Mon Dec 14, 2015 03:48 PM UTC by Heith Seewald
**Last Updated:** Fri Jan 22, 2016 01:05 AM UTC
**Owner:** Heith Seewald
**Attachments:**
-
[.eslintrc](https://forge-allura.apache.org/p/allura/tickets/8035/attachment/.eslintrc)
(416 Bytes; application/octet-stream)
-
[.jscsrc](https://forge-allura.apache.org/p/allura/tickets/8035/attachment/.jscsrc)
(169 Bytes; application/octet-stream)
Finalize and cleanup our eslint/jscsrc setup.
This can be a working standard that evolves over time -- but we should get
something in place now so that we can start collecting feedback.
*(Dave has a few tweaked config files attached - they need more work though)*
Then apply these styles to [#7919].
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
