Looking good, just a few things I want to suggest to make the code more readable & maintanable. The sorting line has a lot in it, and its not immediately obvious what it's doing, so a comment like "sort by filename" would help. Also it would be good to follow "pep8" formatting guidelines, e.g. `onlyChangedFiles=True` instead of `onlyChangedFiles = True` and only one space before `onlyChangedFiles` (you have two spaces in a few places). I would recommend installing/configuring a pep8 tool for your editor. That will show you whenever your formatting doesn't follow the guidelines. (But don't worry about any existing violations, we just want new/changed code to follow the guidelines).
ForgeHg will need to be updated as well since it has a `paged_diffs` method. At the very least it needs to handle the `onlyChangedFiles` parameter being passed in and ignore it. Better would be to try an Hg repo and see if it includes directories and if so then make it skip them based on that parameter. https://sourceforge.net/p/forgehg/code/ci/master/tree/forgehg/model/hg.py#l523 If you can fork that repo and make a merge request for it, that'd be great. --- ** [tickets:#7949] Better listing of files changed in a certain commit** **Status:** in-progress **Milestone:** unreleased **Labels:** ux **Created:** Tue Aug 04, 2015 10:10 PM UTC by Dave Brondsema **Last Updated:** Fri Apr 01, 2016 08:40 PM UTC **Owner:** Pranav Sharma Followup to [#7925] sort of - at least things noticed from there. Would be nice to show copies and renames a little differently. Not sure how though. On a commit view for git, every parent directly is always listed as a change. This is due to `-t` in the `git.diff_tree` call. We should be able to replace this with `-r` (with some confirmation that `added_paths()` still works right) Commit views should list all files in alphabetical order, rather than grouped by add/remove/etc. Make sure paginating through it works correctly still too. --- Sent from forge-allura.apache.org because [email protected] is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
