- **Milestone**: unreleased --> v1.8.0


---

** [tickets:#7896] Better plaintext mail for commit notifications**

**Status:** closed
**Milestone:** v1.8.0
**Created:** Fri Jun 12, 2015 06:25 PM UTC by Dave Brondsema
**Last Updated:** Wed Jul 12, 2017 03:58 PM UTC
**Owner:** Dave Brondsema


Our plaintext mail messages just send markdown without converting it to HTML.  
So all plain text views will see some markdown formatting.  Commit 
notifications also include HTML tags in each commit message.  This is from the 
`summary = g.markdown_commit.convert(ci.message)` in `def send_notifications` 
rendering commit-markdown -> HTML.  (Before [#7825] the commit message text was 
just passed through without this step but that caused inadvertent markdown 
formatting for things like `__init__`, or `if (*pArray[j+1] > *pArray[j])`

Example of the HTML coming through in plain text: 
https://forge-allura.apache.org/p/allura/pastebin/557b1ce16d19cd7007456025

I think a fix for this would have to include a way for commit notification 
logic to build the plain text version separately and pass that in to the mail 
functions.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to