- **status**: review --> open - **Reviewer**: Dave Brondsema - **Comment**:
Nice overall structure, and commenting/documentation. This is going to be great. * `memorable_forget`'s `_inner` should only catch HTTP exceptions I think. Safer and more clear about what its doing. * Does the SimpleMDE config `autosave:true` do anything? * there are some `sisyphus` references I don't think we need * blog post successful submit doesn't set memorable_forget cookie. Same for a nested reply. ### `memorable.js` * shouldn't use a `SF` namespace * `Memorable.initialize` looks to do similar work as `Memorable.add`, could it call `add`? * `name.length != 28` - what is that about? * the loop`i = 3; i < list.length`... also could do .slice() and .join() instead of a loop * commenting on a blog post generates storage key `/p/test/blog/_discuss/thread/ce912605/post__None` is that None ok? same for creating a new discussion topic. * memorable_forget cookie only triggers clearing if memorable.js runs on the page? Not too big a deal since the cookie will stick around until you visit a page with it, but maybe better to have clearing behavior run separate from the saving behavior ### User Experience * if I intentionally navigate away, it may be surprising to see saved text from long ago when I come back. (even more so if I click "cancel" on a form) * maybe could refine our logic to only save for a duration of time? not sure. At a minimum we could have 'cancel' links clear the storage * probably a separate ticket, but if i get logged out and then try to do a POST I get sent to /auth/ without any return_to. Probably should have a return_to of the referrer (e.g. wiki edit, ticket edit page) * should an intentional logout clear all the local storage? I think so, for privacy. --- ** [tickets:#8196] Save content before form submission** **Status:** open **Milestone:** unreleased **Created:** Wed Mar 14, 2018 06:28 PM UTC by Kenton Taylor **Last Updated:** Wed Mar 14, 2018 06:45 PM UTC **Owner:** Kenton Taylor It would be helpful to save form content before submitting, in case the Antispam spinner/honeypot rejects it, or you get logged out. And obvious restore the content when viewing the form again. Use localStorage? Clear it after a successful submit? And/or after an hour? Also need to deal with spinner field names properly. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
