Changes from 0.3.2 to 2.1.11 that may affect us:

> 2.0.0
> CRITICAL: Diff objects created with patch output will now not carry the — and 
> +++ header lines anymore. All diffs now start with the @@ header line 
> directly. Users that rely on the old behaviour can now (reliably) read this 
> information from the a_path and b_path properties without having to parse 
> these lines manually.

Don't see any evidence of this being used by Allura.

> 1.0.2
> IMPORTANT: Changed default object database of Repo objects to GitCmdObjectDB. 
> The pure-python implementation used previously usually fails to release its 
> resources (i.e. file handles), which can lead to problems when working with 
> large repositories.

We already use GitCmdObjectDB

> 0.3.4.
> Id attribute of Commit objects is now hexsha, instead of binsha. The latter 
> makes no sense in python 3 and I see no application of it anyway besides its 
> artificial usage in test cases.

Looks like `binsha` attribute still exists, so our continued usage of it should 
be ok.

A nice new feature that could be used (esp. in last_commit_doc computations):
https://gitpython.readthedocs.io/en/stable/reference.html#git.cmd.Git.execute 
`kill_after_timeout` parameter.

Make sure to `pip uninstall gitdb smmap` so they aren't installed alongside the 
gitdb2 and smmap2 packages.

The custom patches at https://github.com/johnsca/GitPython/commits/sf-master 
have been applied upstream already, except for 
https://github.com/johnsca/GitPython/commit/f7ed51ba4c8416888f5744ddb84726316c461051
 which seems pretty minor and probably was just handled differently overall.


---

** [tickets:#8200] Update GitPython to support git >= 2.15**

**Status:** in-progress
**Milestone:** unreleased
**Created:** Mon Apr 30, 2018 04:23 PM UTC by Dave Brondsema
**Last Updated:** Thu Aug 09, 2018 08:23 PM UTC
**Owner:** Dave Brondsema


With Git >= 2.15 we get errors like `TypeError: PackingType of packed-Refs not 
understood: '# pack-refs with: peeled fully-peeled sorted'` which is fixed in a 
newer version of GitPython:
https://github.com/gitpython-developers/GitPython/issues/687
https://github.com/gitpython-developers/GitPython/pull/689

That will be a big upgrade so we should so thorough testing.  Also we should 
try to get some GitPython fixes merged into upstream if they haven't yet.  At 
https://github.com/johnsca/GitPython/tree/sf-master there are fixes for 
[#5411], [#6000], [#6078], and [#7021].  (SourceForge uses a custom build that 
includes those fixes, but Allura's requirements.txt version doesn't include 
those)


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to