Good improvements. Was pretty easy to handle old_text for edits I see - nice.
I would also try to use `artifact.link_text()` in the email content, I think that will add a lot of value in showing the thread title, etc. Instead of only mount point name. And the artifact_link URL isn't always right, for example on ticket comments it ends up with a `_discuss` url which is an internal not-really-used thing. `main_url()` could work, or try `url_paginated()` Beyond that this seems pretty good. However I want to wait to merge this until subscribe/unsubscribe in next ticket is done (Don't want to have situations where people get notifications they can't unsubscribe from). So just branch off of this work for the next ticket, that should work fine I think. --- ** [tickets:#8284] gsoc19-c4: Implement the notification email sender** **Status:** in-progress **Milestone:** unreleased **Labels:** gsoc19 **Created:** Wed May 08, 2019 03:03 PM UTC by Shalitha Suranga **Last Updated:** Thu Jul 18, 2019 06:08 PM UTC **Owner:** Shalitha Suranga *Todo* This function is responsible for detecting user mentions and sending email notifications. For the detection markdown extenstion can be reused. For sending emails existing interfaces can be used; or any other better mechanism will be discussed before the implementation. *What is expected* When a user is mentioned (and the markdown is saved) the relevant user will be notified with an email --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
