* `allow_umnotif and True or False` is kinda confusing to me to read. How about `bool(allow_umnotif)` instead? * small grammar improvement: `Send a notification via e-mail if my username is mentioned in somewhere` remove "in" so it is just `... mentioned somewhere` * we should add an audit log entry when the preference is changed (use `h.auditlog_user`)
Suggestions for next steps / further work: * like you said - merge this branch with ss/8284 and check the preference * a script to update all existing users to set the notification preference (see `Allura/allura/scripts/backfill_previous_login_details.py` as an example of the general idea (although it accidentally has pagesize=2 that shouldn't be there). * default new users to have the notification preference on * in the notification emails, have an unsubscribe link that goes to the subscriptions page and the preference form --- ** [tickets:#8285] gsoc19-c5: Add an area for user mentions notifications** **Status:** review **Milestone:** unreleased **Labels:** gsoc19 **Created:** Wed May 08, 2019 03:26 PM UTC by Shalitha Suranga **Last Updated:** Sun Jul 28, 2019 03:43 PM UTC **Owner:** Shalitha Suranga *Todo* An option to turn on/off notifications for user mentions to be added to the subscriptions tab. An endpoint can be implemented to save the user setting for sending notifications. *What is expected* Allura user can turn on/off user mention notifications. If the user has disabled the setting, notification emails will not be sent. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
