Hi,

After merging this I noticed a minor issue, but wanted to let you know and see 
if you were interested in doing a little bit more cleanup.  
[PEP8](https://www.python.org/dev/peps/pep-0008/) is a code style guideline for 
python and there are various tools to check and to enforce it.  We're not super 
strict about it with Allura, but we like to follow the guidelines when 
possible.  `ForgeImporters/forgeimporters/tests/forge/test_discussion.py` and 
`ForgeImporters/forgeimporters/forge/discussion.py` have quite a few places 
that don't follow PEP8 exactly.  Do you want to see about tidying them up?  
Depending on your editor, you may have an option to automatically reformat the 
files.  Or you can use a tool `flake8` or `autopep8`.  In all cases, please set 
the max line length to 119 (that is the setting we use for Allura, some tools 
may pick it up automatically but some might default to a smaller width can 
cause extra line wrapping which we don't like).

Thanks!


---

** [tickets:#7935] Forum importer for allura's own export format**

**Status:** closed
**Milestone:** unreleased
**Labels:** import 
**Created:** Tue Jul 21, 2015 06:53 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 13, 2020 05:42 PM UTC
**Owner:** Fahri





---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to