Yea I think that is a good approach so we keep any other parameters.  Its the 
safest for now so we don't drop a parameter by mistake.  It does mean if there 
is a junk parameter like `?asf=asf` somehow it'll still be in the canonical.  
If that turns out to be an issue, we can revisit then.

One last issue I found, if you are on `page=1`, then the `rel=prev` tag has 
`page=0` in the URL but it be better to not to say `page=0` and just leave that 
part off.  Also the pagination links do the same thing, in `page_list.html` 
with the `paginator` library, is it possible for them to omit when `page=0`?


---

** [tickets:#8444] Add Canonical Link For Tool Sections **

**Status:** open
**Milestone:** unreleased
**Created:** Tue Jun 28, 2022 05:50 PM UTC by Guillermo Cruz
**Last Updated:** Fri Jul 15, 2022 02:44 PM UTC
**Owner:** Guillermo Cruz


Tools like Tickets, Wikis, Discussions, etc. should include a canonical link. 
Also on sections with pagination include `page=x` in the root url and 
`rel="next"` `rel="next"` tags


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to