roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores URL: https://github.com/apache/incubator-amaterasu/pull/39#discussion_r247366732
########## File path: leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/configuration/ConfigManager.kt ########## @@ -68,4 +73,16 @@ class ConfigManager(private val env: String, private val repoPath: String, priva fun getActionConfigContent(action: String, path: String = ""): String { return getActionConfiguration(action, path).toYaml.toText() } + + fun getFileDataSetConfigurations(): Map<String, FileDataSet> { Review comment: Ideally, this should ideally be all in one datasetConfiguration function, we should only know a name for it. Which means we need a base dataset config as well, maybe with a field describing the type for casting? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services