-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16877/#review31884
-----------------------------------------------------------
Ship it!
Minor nits:
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
The various task counts seem to have been stored as integer. Do we need to call
toString() and then ParseInt?
e.g.
batchRequestResponse.setAbortedTaskCount(Integer.parseInt(requestMap.get(REQUESTS_ABORTED_TASKS_KEY).toString())
It seems that the tolerance level is based on failed number of task vs total
number of tasks currently known. We need to document that properly. For
example, if a batch has two request with 3 tasks for first and 20 for second
and a tolerance of 50% - if 2 tasks fail for the first request, it will fail
the whole batch.
- Sumit Mohanty
On Jan. 15, 2014, 12:08 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16877/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 12:08 a.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-4293
> https://issues.apache.org/jira/browse/AMBARI-4293
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Support percentage based failure tolerance on the tasks that result from a
> Request Schedule.
>
> Note: This will be an at least limit, meaning in a chain of requests, if
> executing a request results in the tolerance percentage being exceeded, the
> proceeding request will never get scheduled.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
> 98e7b4e
>
> ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestJob.java
> 9fbb571
>
> ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestResponse.java
> 59a45fd
>
> ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecutionImpl.java
> a1e7d53
>
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
> 19105e0
>
> ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java
> 8768645
>
> Diff: https://reviews.apache.org/r/16877/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
