> On Jan. 16, 2014, 2:55 p.m., Dmytro Sen wrote:
> > As a proposal, we could add an ability to provide default values for the
> > optional parameters during new custom action definition. For example,
> > default threshold = 20%.
> > In this case the user is able to use the default value or override it.
And I think we should change custom_actions_dir value
/ambari-agent/src/main/python/ambari_agent/AmbariConfig.py as well
{code}
[python]
custom_actions_dir = /var/lib/ambari-agent/resources
{code}
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16942/#review32029
-----------------------------------------------------------
On Jan. 16, 2014, 2:11 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16942/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 2:11 a.m.)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-4308
> https://issues.apache.org/jira/browse/AMBARI-4308
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See JIRA description.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini e663a25
> ambari-agent/pom.xml 3be0a1e
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
> 4e32f2a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff2b480
> ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalance.py
> PRE-CREATION
> ambari-server/src/main/resources/custom_actions/hdfs_rebalance.py 6426855
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> 82a66e1
>
> Diff: https://reviews.apache.org/r/16942/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.controller.AmbariManagementControllerTest
> Tests run: 101, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 122.337 sec
>
> Results :
>
> Tests run: 101, Failures: 0, Errors: 0, Skipped: 5
>
>
> Thanks,
>
> Sumit Mohanty
>
>
