-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17137/#review32492
-----------------------------------------------------------
Ship it!
LGTM,
Calls like:
curl -H "X-Requested-By:ambari" -u admin:admin -X POST
-d'{"RequestInfo":{"context":"HDFS Rebalance", "action" :
"ambari_hdfs_rebalancer", "service_name" : "HDFS", "component_name":"NAMENODE",
"hosts":"c6401.ambari.apache.org", "parameters" : {"threshold" : "20",
"principal" : "[email protected]", "keytab" :
"/etc/security/keytabs/hdfs.headless.keytab"}}}'
http://c6401:8080/api/v1/clusters/c1/requests
are executed successfully right after cluster deployment. Tested on HDP2.1.1
BTW, since namenode is the most loaded server in the cluster, we could run HDFS
rebalance at any HDFS client, not only NAMENODE.
- Dmytro Sen
On Jan. 21, 2014, 11:48 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17137/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 11:48 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Mahadev Konar, and Sid Wagle.
>
>
> Bugs: AMBARI-4365
> https://issues.apache.org/jira/browse/AMBARI-4365
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See the attached JIRA.
>
>
> Diffs
> -----
>
> ambari-server/conf/unix/ambari.properties 978cdc6
> ambari-server/pom.xml 02fd326
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDefinition.java
> fdd57dd
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
> 8e6fb13
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CustomActionDBAccessor.java
> b861e76
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CustomActionDBAccessorImpl.java
> 38bc371
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
> 56bd5e9
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> 7c8bbdf
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionResponse.java
> f85f640
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
> d985d9f
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> 7aa39a8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> 54ab41c
>
> ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionSpec.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionXml.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ActionDefinitionDAO.java
> df1f71a
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ActionEntity.java
> 7f1d031
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 561ac73
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5aa356a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 63c5f4b
>
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
> PRE-CREATION
> ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalance.py
> 710c9c6
> ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py
> PRE-CREATION
> ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Oracle-UPGRADE.sql
> 19768e7
>
> ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Postgres-UPGRADE-1.3.0.sql
> bb02aba
>
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
> c09c8bb
>
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
> 648e935
>
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
> 5925fbb
>
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestCustomActionDBAccessorImpl.java
> 55d2021
>
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
> 7b07062
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> 1ecb9ca
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java
> 271187b
>
> ambari-server/src/test/java/org/apache/ambari/server/customactions/ActionDefinitionManagerTest.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ActionDefinitionDAOTest.java
> cf87023
>
> ambari-server/src/test/resources/custom_action_definitions/cust_action_definitions1.xml
> PRE-CREATION
>
> ambari-server/src/test/resources/custom_action_definitions/cust_action_definitions2.txt
> PRE-CREATION
>
> ambari-server/src/test/resources/custom_action_definitions/cust_action_definitions3.xml
> PRE-CREATION
>
> ambari-server/src/test/resources/custom_action_definitions/system_action_definitions.xml
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17137/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Main ....................................... SUCCESS [0.628s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.240s]
> [INFO] Ambari Web ........................................ SUCCESS [7.190s]
> [INFO] Ambari Server ..................................... FAILURE
> [11:32.113s]
>
> Known issue:
> Tests in error:
>
> testFinalizeBatch(org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest):
> No constructor matching arguments can be found
>
>
> Thanks,
>
> Sumit Mohanty
>
>
