----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17394/#review32834 -----------------------------------------------------------
Overall, changes look good. The only issue is that permission modes for files are specified as decimals, and not octal numbers (hard to read and understand) - Dmitro Lisnichenko On Jan. 27, 2014, 4:18 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17394/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 4:18 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-4427 > https://issues.apache.org/jira/browse/AMBARI-4427 > > > Repository: ambari > > > Description > ------- > > Unittests for hooks, GANGLIA, FALCON and SQOOP. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon_client.py > ab59b6f > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon_server.py > fa3bc40 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/GANGLIA/package/scripts/ganglia_server.py > ab730de > ambari-server/src/test/python/stacks/1.3.3/GANGLIA/test_ganglia_monitor.py > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.3/GANGLIA/test_ganglia_server.py > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.3/SQOOP/test_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.3/SQOOP/test_sqoop.py PRE-CREATION > > ambari-server/src/test/python/stacks/1.3.3/hooks/before-INSTALL/test_before_install.py > PRE-CREATION > > ambari-server/src/test/python/stacks/1.3.3/hooks/before-START/test_before_start.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_client.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_server.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/FALCON/test_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/GANGLIA/test_ganglia_monitor.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/GANGLIA/test_ganglia_server.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/SQOOP/test_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/SQOOP/test_sqoop.py PRE-CREATION > ambari-server/src/test/python/stacks/2.1.1/configs/default.json 9069853 > ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 1d2fa15 > > ambari-server/src/test/python/stacks/2.1.1/hooks/before-INSTALL/test_before_install.py > PRE-CREATION > > ambari-server/src/test/python/stacks/2.1.1/hooks/before-START/test_before_start.py > PRE-CREATION > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 30e8366 > ambari-server/src/test/python/unitTests.py 03c67fd > > Diff: https://reviews.apache.org/r/17394/diff/ > > > Testing > ------- > > All tests passed: > Running tests for stack:1.3.3 service:before-START > test_hook_default (test_before_start.TestHookBeforeStart) ... ok > > ---------------------------------------------------------------------- > Ran 1 test in 0.034s > > OK > Running tests for stack:1.3.3 service:before-INSTALL > test_hook_default (test_before_install.TestHookBeforeInstall) ... ok > > ---------------------------------------------------------------------- > Ran 1 test in 0.004s > > OK > > Running tests for stack:2.1.1 service:before-START > test_configure_default (test_before_start.TestHookBeforeStart) ... ok > > ---------------------------------------------------------------------- > Ran 1 test in 0.034s > > OK > Running tests for stack:2.1.1 service:before-INSTALL > test_configure_default (test_before_install.TestHookBeforeInstall) ... ok > > ---------------------------------------------------------------------- > Ran 1 test in 0.004s > > OK > Running tests for stack:2.1.1 service:FALCON > test_configure_default (test_falcon_server.TestFalconServer) ... ok > test_start_default (test_falcon_server.TestFalconServer) ... ok > test_stop_default (test_falcon_server.TestFalconServer) ... ok > test_service_check (test_service_check.TestFalconServer) ... ok > test_configure_default (test_falcon_client.TestFalconClient) ... ok > > ---------------------------------------------------------------------- > Ran 5 tests in 0.027s > Running tests for stack:1.3.3 service:GANGLIA > test_configure_default (test_ganglia_server.TestGangliaServer) ... ok > test_start_default (test_ganglia_server.TestGangliaServer) ... ok > test_stop_default (test_ganglia_server.TestGangliaServer) ... ok > test_configure_default (test_ganglia_monitor.TestGangliaMonitor) ... ok > test_start_default (test_ganglia_monitor.TestGangliaMonitor) ... ok > test_stop_default (test_ganglia_monitor.TestGangliaMonitor) ... ok > > ---------------------------------------------------------------------- > Ran 6 tests in 0.017s > > OK > Running tests for stack:2.1.1 service:GANGLIA > test_configure_default (test_ganglia_monitor.TestGangliaMonitor) ... ok > test_start_default (test_ganglia_monitor.TestGangliaMonitor) ... ok > test_stop_default (test_ganglia_monitor.TestGangliaMonitor) ... ok > test_configure_default (test_ganglia_server.TestGangliaServer) ... ok > test_start_default (test_ganglia_server.TestGangliaServer) ... ok > test_stop_default (test_ganglia_server.TestGangliaServer) ... ok > > ---------------------------------------------------------------------- > Ran 6 tests in 0.019s > Running tests for stack:2.1.1 service:SQOOP > test_configure_default (test_sqoop.TestSqoop) ... ok > test_service_check_default (test_service_check.TestSqoopServiceCheck) ... ok > test_service_check_secured (test_service_check.TestSqoopServiceCheck) ... ok > > ---------------------------------------------------------------------- > Ran 3 tests in 0.008s > Running tests for stack:2.1.1 service:SQOOP > test_configure_default (test_sqoop.TestSqoop) ... ok > test_service_check_default (test_service_check.TestSqoopServiceCheck) ... ok > test_service_check_secured (test_service_check.TestSqoopServiceCheck) ... ok > > ---------------------------------------------------------------------- > Ran 3 tests in 0.008s > > > Thanks, > > Eugene Chekanskiy > >
