----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17393/#review32841 -----------------------------------------------------------
LGTM except missing unit tests - Dmitro Lisnichenko On Jan. 27, 2014, 3:24 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17393/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 3:24 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty. > > > Bugs: AMBARI-4425 > https://issues.apache.org/jira/browse/AMBARI-4425 > > > Repository: ambari > > > Description > ------- > > Similar to Oracle/Postgres we need to make sure that ambari-server > upgradestack works for MySQL > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 2ace986 > > ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql > PRE-CREATION > > Diff: https://reviews.apache.org/r/17393/diff/ > > > Testing > ------- > > > Thanks, > > Vitalyi Brodetskyi > >
