----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17396/#review32844 -----------------------------------------------------------
Ship it! As well as we are adding clock to only server component, maybe we should cover with unit test case and ensure, that server clock is absent in response for agent component? The rest LGTM, +1. - Oleksandr Diachenko On Jan. 27, 2014, 6:12 p.m., Dmytro Shkvyra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17396/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 6:12 p.m.) > > > Review request for Ambari, Oleksandr Diachenko and Sid Wagle. > > > Bugs: AMBARI-4432 > https://issues.apache.org/jira/browse/AMBARI-4432 > > > Repository: ambari > > > Description > ------- > > Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER. > This should be in UNIX epoch time format (i.e., just a "long") > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java > 4c5320f > ambari-server/src/main/resources/properties.json 1e555c2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java > a49ad22 > > Diff: https://reviews.apache.org/r/17396/diff/ > > > Testing > ------- > > Unitestst added. Tested at Centos 6.3/6.4 > > > Thanks, > > Dmytro Shkvyra > >
