-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17429/#review32913
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
- Line 536: isDrainOnlyRequest.equals("true") ||
isDrainOnlyRequest.equals("false"): Can be simplified as,
Boolean.parseBoolean(isDrainOnlyRequest)
Rest looks good.
- Sid Wagle
On Jan. 27, 2014, 11:36 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17429/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 11:36 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Sid Wagle.
>
>
> Bugs: AMBARI-4441
> https://issues.apache.org/jira/browse/AMBARI-4441
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See the attached JIRA.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> 5baa72e
>
> ambari-server/src/main/resources/stacks/HDP/1.3.3/services/HBASE/package/scripts/hbase_decommission.py
> PRE-CREATION
>
> ambari-server/src/main/resources/stacks/HDP/1.3.3/services/HBASE/package/scripts/hbase_master.py
> d94b4b4
>
> ambari-server/src/main/resources/stacks/HDP/1.3.3/services/HBASE/package/scripts/params.py
> b830412
>
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/HBASE/package/scripts/hbase_decommission.py
> PRE-CREATION
>
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/HBASE/package/scripts/hbase_master.py
> d94b4b4
>
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/HBASE/package/scripts/params.py
> 8205971
> ambari-server/src/test/python/stacks/1.3.3/HBASE/test_hbase_master.py
> 6566415
> ambari-server/src/test/python/stacks/1.3.3/configs/default.json 556853a
> ambari-server/src/test/python/stacks/1.3.3/configs/secured.json fac4974
> ambari-server/src/test/python/stacks/2.1.1/HBASE/test_hbase_master.py
> 12fb388
> ambari-server/src/test/python/stacks/2.1.1/configs/default.json 7d4e9a6
> ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 6ad9e32
>
> Diff: https://reviews.apache.org/r/17429/diff/
>
>
> Testing
> -------
>
> Unit tests passed for the decommission script.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
