-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 6:46 p.m.)
Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid
Wagle.
Bugs: AMBARI-4461
https://issues.apache.org/jira/browse/AMBARI-4461
Repository: ambari
Description
-------
Add code to enable the deployment of a View in Ambari.
This is the 3rd Ambari View checkin after the interfaces and configuration.
This patch should make is possible to deploy Views into Ambari.
The changes include ...
1) the API framework changes needed to add Views and ViewInstance resource
types to the Ambari REST API
2) the View framework needed to deploy and access views
3) unit tests for the new view framework
Some View features not addressed in this patch ...
1) persistent view instances in Ambari DB
2) view security
3) more flexible view UI features
4) view access to Ambari DB
5) default resource provider to persist View resource to Ambari DB
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
de6307c
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
b070d98
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
00f1b74
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
a10835e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
6a82e59
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java
3b0c12a
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96
Diff: https://reviews.apache.org/r/17503/diff/
Testing
-------
Added new unit tests for view classes.
All ambari-server unit tests pass :
Results :
Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
Thanks,
Tom Beerbower
