-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17463/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 7:12 p.m.)
Review request for Ambari, Dmytro Sen and Sumit Mohanty.
Bugs: AMBARI-4358
https://issues.apache.org/jira/browse/AMBARI-4358
Repository: ambari
Description
-------
Patch contains implementation and unit test coverage for stack extension for
per-service:
- os specifics (package definitions and repository)
- command scripts
- custom commands
- hook directories
- package folders (containing scripts, files and templates)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
7ffc1c9
ambari-agent/src/main/python/ambari_agent/FileCache.py eafb592
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py
dadc793
ambari-agent/src/test/python/ambari_agent/TestFileCache.py ae84268
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
c430c13
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
6616b4f
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
78131f2
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
0883ad4
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
72fc31d
ambari-server/src/main/java/org/apache/ambari/server/state/CommandScriptDefinition.java
3394ecd
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java
8798ef1
ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
ab4143f
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
c45531f
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java
6affad9
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
3a348e7
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
6edb3df
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
251aa5f
ambari-server/src/test/python/stacks/1.3.3/configs/default.json 70b93f5
ambari-server/src/test/python/stacks/1.3.3/configs/secured.json ac357cc
ambari-server/src/test/python/stacks/2.1.1/configs/default.json 5b40256
ambari-server/src/test/python/stacks/2.1.1/configs/secured.json b000c56
ambari-server/src/test/resources/stacks/HDP/2.0.6/hooks/dummy-script.py
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.7/metainfo.xml 07da411
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/package/dummy-script.py
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/scripts/hbase.py
0a169a4
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/scripts/hbase_client.py
8a4d0e0
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/scripts/hbase_master.py
0a169a4
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/scripts/hbase_regionserver.py
0a169a4
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metainfo.xml
3de6ce5
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/dummy-script.py
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/files/checkForFormat.sh
d14091a
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/files/checkWebUI.py
f8e9c1a
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/datanode.py
eaa27cf
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_client.py
6babde5
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_datanode.py
e0b6c39
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_namenode.py
ecda794
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_snamenode.py
a943455
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/journalnode.py
fd355cc
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/namenode.py
c799415
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/params.py
568a8a8
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/service_check.py
d27b13a
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/snamenode.py
8f682ec
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/status_params.py
4097373
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/utils.py
225cd2e
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/zkfc_slave.py
f415f24
ambari-server/src/test/resources/stacks/HDP/2.0.8/hooks/dummy-script.py
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/repos/repoinfo.xml
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/role_command_order.json
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HBASE/metainfo.xml
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metainfo.xml
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/package/dummy-script.py
PRE-CREATION
Diff: https://reviews.apache.org/r/17463/diff/
Testing (updated)
-------
Server java tests:
Results :
Tests run: 1360, Failures: 0, Errors: 0, Skipped: 7
Server python tests fail (random fails of 0-7 webhcat-related tests) both on
trunk and with my patch.
Agent tests:
----------------------------------------------------------------------
Ran 236 tests in 12.323s
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko
