----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17725/#review33675 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java * Do we need a lock around executionScheduler.startScheduler(null)? What if as ambari-server is automatically starting the scheduler a call comes in that also tries to start the scheduler. This will not fix the problem if user does not make any call to create a new batch API. We can note this issue somewhere. - Sumit Mohanty On Feb. 4, 2014, 9:35 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17725/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 9:35 p.m.) > > > Review request for Ambari, Mahadev Konar and Sumit Mohanty. > > > Bugs: AMBARI-4527 > https://issues.apache.org/jira/browse/AMBARI-4527 > > > Repository: ambari > > > Description > ------- > > Problem description: > > Batch request to do rolling restart does not work. > The API says "201 created", but no requests are created. > > Reason: > > Server clock synced up with NTP daemon and was reset after Scheduler > initialize and before Scheduler start. > This caused the Thread.sleep() in the Scheduler.startDelayed() to be paused > for a long time since the native implementation relies on server clock. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java > d6d0439 > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduler.java > f75eb94 > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionSchedulerImpl.java > 488564f > > ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionSchedulerTest.java > 89c8d26 > > Diff: https://reviews.apache.org/r/17725/diff/ > > > Testing > ------- > > > Thanks, > > Sid Wagle > >
