> On Feb. 10, 2014, 9:13 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py, > > line 62 > > <https://reviews.apache.org/r/17916/diff/1/?file=482051#file482051line62> > > > > as far as I know, we always install gmond on all hosts (including > > gmetad host), so we probably should not generate gmond configs at > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py > > Dmytro Shkvyra wrote: > In ganglia_server.py I have created master for HDPSlaves
you are right, I've missed that at ganglia_server we generate server-side gmond configs > On Feb. 10, 2014, 9:13 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py, > > line 62 > > <https://reviews.apache.org/r/17916/diff/1/?file=482054#file482054line62> > > > > gmond config generation at gmetad script > > Dmytro Shkvyra wrote: > In ganglia_server.py I have created master for HDPSlaves you are right, I've missed that at ganglia_server we generate server-side gmond configs - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17916/#review34100 ----------------------------------------------------------- On Feb. 10, 2014, 8:06 p.m., Dmytro Shkvyra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17916/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 8:06 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar. > > > Bugs: AMBARI-4585 > https://issues.apache.org/jira/browse/AMBARI-4585 > > > Repository: ambari > > > Description > ------- > > Reconfigure ganglia monitors, master and slave components > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py > 207331b > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py > 7fa747a > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py > 97ef6bb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py > 4abdb9b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py > 863f092 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py > 601601e > ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py > a1ba41c > ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py > 61f3735 > ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py > 870bc22 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab > > Diff: https://reviews.apache.org/r/17916/diff/ > > > Testing > ------- > > > Thanks, > > Dmytro Shkvyra > >
