----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18136/#review34525 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Feb. 14, 2014, 6:15 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18136/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 6:15 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-4684 > https://issues.apache.org/jira/browse/AMBARI-4684 > > > Repository: ambari > > > Description > ------- > > Passwords for nagios, hive and oozie with special bash symbols like ' " ` ! > and whitespaces > cause tasks to fail. > > Add a format flag to resource_management formatter, and use the flag for the > passwords. > > > Diffs > ----- > > > ambari-agent/src/main/python/resource_management/libraries/functions/format.py > 5320d2a > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py > 640049a > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 6fa2721 > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_mysql_server.py > 62a0ac7 > ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_nagios_server.py > 93c75d3 > ambari-server/src/test/python/stacks/1.3.2/configs/default.json 653be3c > ambari-server/src/test/python/stacks/1.3.2/configs/secured.json e711ff2 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py > 2ed7e6c > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ee6d03c > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py > ef73403 > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py > c48bb7e > ambari-server/src/test/python/stacks/2.0.6/configs/default.json d3d5ba3 > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 61a4830 > > Diff: https://reviews.apache.org/r/18136/diff/ > > > Testing > ------- > > 1. Deploying with weird passwords. > 2. Unnitets successfull. > > > Thanks, > > Andrew Onischuk > >
