----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18140/#review34543 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On Feb. 14, 2014, 7:33 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18140/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 7:33 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Repository: ambari > > > Description > ------- > > * Modify the resource provider to check multiple properties to find the JMX > port > * Add YARN metrics properties > * Modify test case > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 3053998 > ambari-server/src/main/java/org/apache/ambari/server/state/Service.java > b4238e0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > 0b5f660 > > Diff: https://reviews.apache.org/r/18140/diff/ > > > Testing > ------- > > Only one test change: > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up JAVA_TOOL_OPTIONS: -Djava.awt.headless=true > Running org.apache.ambari.server.controller.internal.JMXHostProviderTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.8 sec > > Results : > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Nate Cole > >
