----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18132/#review34778 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On Feb. 14, 2014, 5:26 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18132/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 5:26 p.m.) > > > Review request for Ambari, Andrew Onischuk and Sid Wagle. > > > Bugs: AMBARI-4481 > https://issues.apache.org/jira/browse/AMBARI-4481 > > > Repository: ambari > > > Description > ------- > > All features are described at jira > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-agent.ini 11d6f1a > ambari-agent/pom.xml d037d46 > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 942cc75 > ambari-agent/src/main/python/ambari_agent/Controller.py b842b4d > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 95ad2cd > ambari-agent/src/main/python/ambari_agent/FileCache.py 01d2e52 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 1918641 > ambari-agent/src/test/python/ambari_agent/TestController.py b4439e9 > ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py > 971048b > ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5e389d5 > ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 906244d > ambari-agent/src/test/python/ambari_agent/dummy_files/dummy_archive.zip > PRE-CREATION > ambari-server/pom.xml 1d6b427 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 2babd6b > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 7f2d1fb > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > e4ebc1c > ambari-server/src/main/python/ambari-server.py 61233d3 > ambari-server/src/main/python/ambari_server/__init__.py PRE-CREATION > ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py > PRE-CREATION > ambari-server/src/test/python/TestAmbariServer.py b473031 > ambari-server/src/test/python/TestResourceFilesKeeper.py PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/active_stack/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/configuration/hive-site.xml > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/.hash > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/addMysqlUser.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/hcatSmoke.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/hiveSmoke.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/hiveserver2.sql > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/hiveserver2Smoke.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/pigSmoke.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/startHiveserver2.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/files/startMetastore.sh > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/__init__.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hcat.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hcat_client.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hcat_service_check.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hive.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hive_client.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hive_metastore.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hive_server.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hive_service.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/mysql_server.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/mysql_service.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/params.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/templates/hcat-env.sh.j2 > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/templates/hive-env.sh.j2 > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/inactive_stack/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/18132/diff/ > > > Testing > ------- > > manual E2E testing: > - checked that files are (re)downloaded after agent restart > - checked that files are downloaded only once > - checked that after server restart files are regenerated > - checked hashing/archivation/downloading extremely big sets of files (~200 > megabytes) > - checked execution under non-root user > - checked agent behaviour in case of inaccessible file (404) with different > tolerate_download_failures option values. > - checked rpm file layout > - checked execution of status commands after cleaning cache and restarting > agent > - could not check HTTPS mode because it is broken (created jira for that). > Theoretically, downloading over HTTPS should work because I use the same URL > as is used for downloading JDK, but I could not test it > > > unit tests: > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [0.418s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.048s] > [INFO] Ambari Web ........................................ SUCCESS [8.266s] > [INFO] Ambari Views ...................................... SUCCESS [3.035s] > [INFO] Ambari Server ..................................... SUCCESS > [12:27.491s] > [INFO] Ambari Agent ...................................... SUCCESS [11.711s] > [INFO] Ambari Client ..................................... SUCCESS [0.204s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 12:51.632s > [INFO] Finished at: Fri Feb 14 19:42:48 FET 2014 > [INFO] Final Memory: 25M/331M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
