----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18474/#review35421 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Feb. 25, 2014, 5:49 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18474/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 5:49 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-4809 > https://issues.apache.org/jira/browse/AMBARI-4809 > > > Repository: ambari > > > Description > ------- > > Added two configs falcon-runtime.properties and falcon-startup.properties and > also log and pid directories. This will allow to add any property for falcon. > Also all default properties described in falcon-xxxxx.properties.xml. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py > 5fdfd50 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > c238471 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/falcon-runtime.properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/falcon-startup.properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/global.xml > 1d56238 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/metainfo.xml > 7836401 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py > 1cedbdf > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py > fa7532d > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/service_check.py > df40af7 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/status_params.py > 395766c > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > 2d0754c > ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_client.py > a725289 > ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_server.py > 7dc1720 > ambari-server/src/test/python/stacks/2.1.1/FALCON/test_service_check.py > 9ae6f67 > ambari-server/src/test/python/stacks/2.1.1/configs/default.json 89c03ab > ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 2631592 > > Diff: https://reviews.apache.org/r/18474/diff/ > > > Testing > ------- > > Tested with default and secured configurations. Unit tests changed > accordingly. > ------------------------------------------------------------------------------- > Total run:497 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Eugene Chekanskiy > >
