-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18483/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sumit Mohanty.
Bugs: AMBARI-4760
https://issues.apache.org/jira/browse/AMBARI-4760
Repository: ambari
Description
-------
In Ambari 1.4.1 and previous versions, a service which only contained client
components would never transition to the "STARTED" state and would instead be
in the "INSTALLED" state.
This seems to have changed in Ambari 1.4.3. Client-only services now transition
to the "STARTED" service, and it seems that trying to transition them to the
"INSTALLED" service generates an error code 400.
The state of the service is now calculated based on the actual states of the
master host components that belong to the service. E.g. if a master component
(NAMENODE for HDFS) is INSTALLED then the state of the service will be
INSTALLED.
What is happening in the case of client only services is that the code is
picking up the default value which happens to be STARTED. This could instead be
computed based on the state of all non-master components - e.g. if all are
INSTALLED then the service state is INSTALLED.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
204d14c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
9f68b0a
Diff: https://reviews.apache.org/r/18483/diff/
Testing
-------
Added new unit tests for client only service state.
All existing unit tests pass :
Results :
Tests run: 1417, Failures: 0, Errors: 0, Skipped: 11
Thanks,
Tom Beerbower
