----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18512/#review35525 -----------------------------------------------------------
Looks good but you forgot the Apache headers for the new files. - Tom Beerbower On Feb. 26, 2014, 2:01 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18512/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 2:01 p.m.) > > > Review request for Ambari and Tom Beerbower. > > > Bugs: AMBARI-4840 > https://issues.apache.org/jira/browse/AMBARI-4840 > > > Repository: ambari > > > Description > ------- > > Metrics sink for both HDP1 and HDP2 versions > > > Diffs > ----- > > contrib/ambari-scom/metrics-sink/pom.xml c005c2e > > contrib/ambari-scom/metrics-sink/src/Test/java/org/apache/hadoop/metrics2/sink/SqlServerSinkHDP1Test.java > PRE-CREATION > > contrib/ambari-scom/metrics-sink/src/Test/java/org/apache/hadoop/metrics2/sink/SqlServerSinkHDP2Test.java > PRE-CREATION > > contrib/ambari-scom/metrics-sink/src/Test/java/org/apache/hadoop/metrics2/sink/SqlServerSinkTest.java > 4d4f6dd > > contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlServerSink.java > 034876a > > contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlServerSinkHDP1.java > PRE-CREATION > > contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlServerSinkHDP2.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18512/diff/ > > > Testing > ------- > > Test result for build with *-Pscom2* profile (by default) > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.hadoop.metrics2.sink.SqlServerSinkHDP2Test > log4j:WARN No appenders could be found for logger > (org.apache.hadoop.metrics2.sink.SqlServerSink). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.765 sec > > Results : > > Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Test result for build with *-Pscom1* profile > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.hadoop.metrics2.sink.SqlServerSinkHDP1Test > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > 14/02/25 01:16:59 INFO sink.SqlServerSink: Entering init > 14/02/25 01:16:59 INFO sink.SqlServerSink: Exit init, cluster name = localhost > Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.556 sec > > Results : > > Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
