-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18515/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 3:03 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.


Bugs: AMBARI-4843
    https://issues.apache.org/jira/browse/AMBARI-4843


Repository: ambari


Description
-------

Ambari-DDL-MySQL-CREATE.sql includes "create ambarirca" database.

{code}
CREATE DATABASE ambarirca;
USE ambarirca;
{code}

1) At minimum, this DDL should not be creating an ambarirca database and 
instead mix in the RCA tables with core Ambari tables (that's how Oracle DDL 
does it -- I think). Not ideal but better than creating an ambarirca database 
in this script (a user would be surprised to see this).
2) Alternatively, we need to split out RCA DDL from the core Ambari. We can doc 
that if you plan to use HDP 1.3.x stack that you need to  to setup an RCA 
database (since RCA is only applicable to those with HDP 1.3.x stack). If we go 
this route, for consistency, we would need to do the same for the oracle DDL.

Note: Right now, looks like the oracle DDL just puts the RCA tables in the same 
database as ambari core tables (basically #1 above).


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 56bb58c 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
 f104259 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2e97b08 

Diff: https://reviews.apache.org/r/18515/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi

Reply via email to