----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18575/#review35638 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On Feb. 27, 2014, 5:41 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18575/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 5:41 p.m.) > > > Review request for Ambari, Mahadev Konar and Nate Cole. > > > Bugs: AMBARI-4871 > https://issues.apache.org/jira/browse/AMBARI-4871 > > > Repository: ambari > > > Description > ------- > > The problem was caused by a saved state (componentName field) inside > JMXPropertyProvider. JMXPropertyProvider is shared between requests, so if > few requests were being processed in parallel (UI issues multiple requests > frequently), things could be messed up. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java > 4de36ca > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > da75ef8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > dc4c5a5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java > 6ce0022 > > ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXPropertyProviderTest.java > c2910db > > ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java > 0c793dc > ambari-server/src/test/resources/stacks/HDP/2.1.1/metainfo.xml PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/repoinfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.1.1/role_command_order.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/configuration/placeholder.txt > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/package/placeholder.txt > PRE-CREATION > ambari-server/src/test/resources/storm_rest_api_jmx.json PRE-CREATION > > Diff: https://reviews.apache.org/r/18575/diff/ > > > Testing > ------- > > Deployed 1-node and 3-node cluster > Tried issuing few metric requests by hands and also checked that jmx and > ganglia metrics/graphs are shown correctly > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [0.159s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.040s] > [INFO] Ambari Web ........................................ SUCCESS [5.304s] > [INFO] Ambari Views ...................................... SUCCESS [3.497s] > [INFO] Ambari Server ..................................... SUCCESS > [11:16.573s] > [INFO] Ambari Agent ...................................... SUCCESS [13.480s] > [INFO] Ambari Client ..................................... SUCCESS [0.409s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 11:39.934s > [INFO] Finished at: Thu Feb 27 20:11:25 FET 2014 > [INFO] Final Memory: 26M/364M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
