----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18589/#review35785 -----------------------------------------------------------
Quick question... Is it possible that a service becomes non-removable during the process of checking its state but before it's removed? If so, could we still end up with partial results? - Tom Beerbower On Feb. 27, 2014, 9:27 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18589/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 9:27 p.m.) > > > Review request for Ambari and Tom Beerbower. > > > Bugs: BUG-4876 > https://issues.apache.org/jira/browse/BUG-4876 > > > Repository: ambari > > > Description > ------- > > * Update error text to something more meaningful. > * Failure will not result in partial results when trying to delete more than > one service. > * Sneak in a fix to NagiosPropertyProvider error logging, it just gets > annoying seeing the same message over and over when it's not really an error. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 8a8b435 > > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java > 90c0e4e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > 2bc51bb > > Diff: https://reviews.apache.org/r/18589/diff/ > > > Testing > ------- > > Results : > > Tests run: 1472, Failures: 0, Errors: 0, Skipped: 11 > > [INFO] > > > Thanks, > > Nate Cole > >
