-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18693/
-----------------------------------------------------------

(Updated March 3, 2014, 5:22 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Changes
-------

Fixed


Bugs: AMBARI-4918
    https://issues.apache.org/jira/browse/AMBARI-4918


Repository: ambari


Description
-------

During setup, if I choose option (3) for a custom JDK, if I put in a valid 
directory, but it's not a JDK, it validates.

Seems like it's only checking that you provided a directory that exists, not 
that it is a java home.

{code}
Do you want to change Oracle JDK [y/n] (n)? y
[1] - Oracle JDK 1.7
[2] - Oracle JDK 1.6
[3] - Custom JDK
==============================================================================
Enter choice (1): 3
WARNING: JDK must be installed on all hosts and JAVA_HOME must be valid on all 
hosts.
WARNING: JCE Policy files are required for configuring Kerberos security. If 
you plan to use Kerberos,please make sure JCE Unlimited Strength Jurisdiction 
Policy Files are valid on all hosts.
Path to JAVA_HOME: /usr
Validating JDK on Ambari Server...done.
Completing setup...
{code}


Diffs (updated)
-----

  ambari-server/src/main/python/ambari-server.py c8abe47 
  ambari-server/src/test/python/TestAmbariServer.py 7281e0b 

Diff: https://reviews.apache.org/r/18693/diff/


Testing
-------

----------------------------------------------------------------------
Ran 188 tests in 1.033s

OK
----------------------------------------------------------------------
Total run:503
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi

Reply via email to